You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "kkalyan (via GitHub)" <gi...@apache.org> on 2026/09/07 17:31:25 UTC

[PR] [MINOR] Refresh search indexes after paragraph edits [zeppelin]

kkalyan opened a new pull request, #5463:
URL: https://github.com/apache/zeppelin/pull/5463

   ### What is this PR for?
   Paragraph edits made through `NotebookService.updateParagraph` or the paragraph REST `PUT` endpoint are saved but do not fire a paragraph update event. As a result, `SearchService` implementations keep the old paragraph text until a full index rebuild or server restart.
   
   This change fires `fireParagraphUpdateEvent` after each successful save, allowing both Lucene and embedding search implementations to refresh the affected paragraph immediately.
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] Refresh search indexes after service-layer paragraph edits
   * [x] Refresh search indexes after REST paragraph edits
   * [x] Add service coverage with a real Lucene search listener
   * [x] Add REST-to-search integration coverage
   
   ### What is the Jira issue?
   No Jira issue has been created yet. This is currently submitted as a `[MINOR]` bug fix.
   
   ### How should this be tested?
   Automated tests:
   
   ```bash
   ./mvnw -pl zeppelin-server -Dtest=NotebookServiceTest,LuceneSearchTest test
   ./mvnw -pl zeppelin-server -Dtest=ZeppelinRestApiTest#testUpdateParagraph test
   ```
   
   The tests update paragraph text through both supported paths and verify that the new text is returned by Lucene search.
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No; this restores expected search-index consistency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Refresh search indexes after paragraph edits [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5463:
URL: https://github.com/apache/zeppelin/pull/5463#issuecomment-5614884424

   Merged into master (3c3c3033).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Refresh search indexes after paragraph edits [zeppelin]

Posted by "kkalyan (via GitHub)" <gi...@apache.org>.
kkalyan commented on PR #5463:
URL: https://github.com/apache/zeppelin/pull/5463#issuecomment-5595985276

   @jongyoul FYA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Refresh search indexes after paragraph edits [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul merged PR #5463:
URL: https://github.com/apache/zeppelin/pull/5463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org