You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/03 03:02:57 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42309: [SPARK-44644][PYTHON] Improve error messages for Python UDTFs with pickling errors
HyukjinKwon commented on code in PR #42309:
URL: https://github.com/apache/spark/pull/42309#discussion_r1282591356
##########
python/pyspark/cloudpickle/cloudpickle_fast.py:
##########
@@ -631,7 +631,7 @@ def dump(self, obj):
try:
return Pickler.dump(self, obj)
except RuntimeError as e:
- if "recursion" in e.args[0]:
+ if len(e.args) > 0 and "recursion" in e.args[0]:
Review Comment:
We should also fix this at https://github.com/cloudpipe/cloudpickle. This file is exactly matched with cloudpickle release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org