You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/26 00:28:28 UTC

[GitHub] [tvm] areusch commented on a diff in pull request #11464: [MLF] Add support for multiple modules in Model Library Format

areusch commented on code in PR #11464:
URL: https://github.com/apache/tvm/pull/11464#discussion_r882219117


##########
python/tvm/micro/model_library_format.py:
##########
@@ -449,47 +498,53 @@ def _eval_shape(param_name, buffer_shape):
     return memory_map
 
 
-def _export_operator_model_library_format(mod: build_module.OperatorModule, tempdir):
+def _export_operator_model_library_format(
+    mods: typing.List[build_module.OperatorModule], tempdir: pathlib.Path

Review Comment:
   i wonder if for operator MLF, we should just not allow multiple module export? if they don't have a mod_name, then we can't really identify them or namespace them properly. wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org