[GitHub] [airflow] Taragolis commented on a diff in pull request #24670: Update AWS Connection docs and deprecate some extras

[GitBox <gi...@apache.org>]

Taragolis commented on code in PR #24670:
URL: https://github.com/apache/airflow/pull/24670#discussion_r907708432


##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -83,6 +83,15 @@ def create_session(self) -> boto3.session.Session:
                 self.extra_config["session_kwargs"],
             )
             session_kwargs = self.extra_config["session_kwargs"]
+
+        if "profile" in self.extra_config and "s3_config_file" not in self.extra_config:

Review Comment:
   Why initially it added in AWS Hook or why I add this warning?
   
   Answer for fist part: https://github.com/apache/airflow/pull/2532#discussion_r145792572 
   Answer for second part: This parameter exist in documentation since version 1.1.0 without mentioning how it actually works, I've just add warning to inform user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org