You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/09 04:06:10 UTC

[GitHub] [commons-beanutils] SethFalco commented on pull request #49: Updated Existing Converters

SethFalco commented on pull request #49:
URL: https://github.com/apache/commons-beanutils/pull/49#issuecomment-876896578


   * I've rebased with master.
   * Squashed my commits.
   * I believe I've resolved all of your feedback.
   
   High hopes everything is cool, but I'll be available if you have any further feedback.
   
   I opted to stick to updating this PR for now rather than split it since it's only getting smaller anyway. (let me know if that's a bother!)
   
   I left some changes in converters I reverted, for example:
   * updating test cases
   * applying conventions to nearby code to what I was modifying
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org