You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "notfilippo (via GitHub)" <gi...@apache.org> on 2025/03/24 09:52:53 UTC
[I] cdata interface with bazel + gazelle requires patches to build [arrow-go]
notfilippo opened a new issue, #327:
URL: https://github.com/apache/arrow-go/issues/327
### Describe the bug, including details regarding any error messages, version, and platform.
After the recent upgrades to v18.1 I have noticed some issues in my bazel + [gazelle](https://github.com/bazel-contrib/bazel-gazelle) build system, which I think are related:
I'm getting
```
Undefined symbols for architecture arm64:
"_ArrowArrayIsReleased", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowArrayIsReleased in 000049.o
"_ArrowArrayMarkReleased", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowArrayMarkReleased in 000051.o
"_ArrowArrayMove", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowArrayMove in 000049.o
"_ArrowArrayRelease", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowArrayRelease in 000049.o
"_ArrowArrayStreamMove", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowArrayStreamMove in 000049.o
"_ArrowArrayStreamRelease", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowArrayStreamRelease in 000049.o
"_ArrowSchemaIsReleased", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowSchemaIsReleased in 000052.o
"_ArrowSchemaMarkReleased", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowSchemaMarkReleased in 000052.o
"_ArrowSchemaRelease", referenced from:
__cgo_a6f56f66f2c3_Cfunc_ArrowSchemaRelease in 000049.o
ld: symbol(s) not found for architecture arm64
```
Which I presume is due to the removal of the `static` qualifier in the function defined `helpers.h`.
Would it be acceptable to introduce a `helpers.c` with the function definitions?
### Component(s)
Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] cdata interface with bazel + gazelle requires patches to build [arrow-go]
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on issue #327:
URL: https://github.com/apache/arrow-go/issues/327#issuecomment-2763236069
Actually, I just checked and the move of the headers from their separate folder to the folder of the cdata module makes [gazelle](https://github.com/bazel-contrib/bazel-gazelle) realize that those .h files should be included in the module build definition, so the compilation succeeds. No point in doing the change then. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] cdata interface with bazel + gazelle requires patches to build [arrow-go]
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo closed issue #327: cdata interface with bazel + gazelle requires patches to build
URL: https://github.com/apache/arrow-go/issues/327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] cdata interface with bazel + gazelle requires patches to build [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #327:
URL: https://github.com/apache/arrow-go/issues/327#issuecomment-2758935608
Any particular reason to move the implementations as opposed to keeping them in the header (for inlining and for ease of updating to keep in sync with Arrow C++)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] cdata interface with bazel + gazelle requires patches to build [arrow-go]
Posted by "notfilippo (via GitHub)" <gi...@apache.org>.
notfilippo commented on issue #327:
URL: https://github.com/apache/arrow-go/issues/327#issuecomment-2747527002
I just saw that the library was upgraded recently with a reintroduction of the `static` qualifiers. Thanks for that. Would we be still interested in moving the implementation in a separate C file instead of keeping the bodies in the header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org