You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Apache Spark (JIRA)" <ji...@apache.org> on 2015/01/07 08:04:34 UTC
[jira] [Commented] (SPARK-5126) No error log for a typo master url
[ https://issues.apache.org/jira/browse/SPARK-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267341#comment-14267341 ]
Apache Spark commented on SPARK-5126:
-------------------------------------
User 'zsxwing' has created a pull request for this issue:
https://github.com/apache/spark/pull/3927
> No error log for a typo master url
> -----------------------------------
>
> Key: SPARK-5126
> URL: https://issues.apache.org/jira/browse/SPARK-5126
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Reporter: Shixiong Zhu
> Priority: Minor
>
> If a typo master url is passed to Worker, it only print the following logs:
> {noformat}
> 15/01/07 14:30:02 INFO worker.Worker: Connecting to master spark://master url:7077...
> 15/01/07 14:30:02 INFO remote.RemoteActorRefProvider$RemoteDeadLetterActorRef: Message [org.apache.spark.deploy.DeployMessages$RegisterWorker] from Actor[akka://sparkWorker/user/Worker#-282880172] to Actor[akka://sparkWorker/deadLetters] was not delivered. [3] dead letters encountered. This logging can be turned off or adjusted with configuration settings 'akka.log-dead-letters' and 'akka.log-dead-letters-during-shutdown'.
> {noformat}
> It's not obvious to know the url is wrong. And {{akka://sparkWorker/deadLetters}} is also confusing. The `deadLetters` Actor is because `actorSelection` will return `deadLetters` for invalid path.
> {code}
> def actorSelection(path: String): ActorSelection = path match {
> case RelativeActorPath(elems) ⇒
> if (elems.isEmpty) ActorSelection(provider.deadLetters, "")
> else if (elems.head.isEmpty) ActorSelection(provider.rootGuardian, elems.tail)
> else ActorSelection(lookupRoot, elems)
> case ActorPathExtractor(address, elems) ⇒
> ActorSelection(provider.rootGuardianAt(address), elems)
> case _ ⇒
> ActorSelection(provider.deadLetters, "")
> }
> {code}
> I think logging an error about invalid url is better.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org