[GitHub] [helix] kaisun2000 commented on a change in pull request #1302: Fix test TestCustomizedViewAggregation

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1302:
URL: https://github.com/apache/helix/pull/1302#discussion_r475926228



##########
File path: helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java
##########
@@ -410,7 +410,11 @@ public void testCustomizedViewAggregation() throws Exception {
     // Aggregating: Type A
     // Routing table: Type A, Type B, Type C
     setAggregationEnabledTypes(Arrays.asList(CustomizedStateType.TYPE_A));
-    validateAggregationSnapshot();
+    // This is commented out as a work around to pass the test
+    // The validation of config change will be done combined with the next several customized state changes
+    // The next validation should only show TYPE_A states aggregated in customized view
+    // Until we fix the issue in routing table provider https://github.com/apache/helix/issues/1296
+//    validateAggregationSnapshot();

Review comment:
       @mgao0 , help me to understand a little bit more here: 
   
   The removal of customized view would cause empty snapshot. In the test case, where is the removal of customizeView type happening? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org