[GitHub] [kafka] showuon commented on pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

[GitBox <gi...@apache.org>]

showuon commented on PR #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-1121114255

   > Seems only reset geneartionId when SyncGroupReqeust got RebalanceInProcess error can be a workaround for this.( i did some test and it works)
   But you didn't do the reset in your final code.
   
   @aiquestion , seems you are right. I forgot to reset the generation ID when SyncGroupReqeust got RebalanceInProcess error. Are you interested in submitting a PR for it? 
   
   But one thing to clarify, after [KAFKA-12984](https://issues.apache.org/jira/browse/KAFKA-12984), [KAFKA-13406](https://issues.apache.org/jira/browse/KAFKA-13406) got fixed, even if the consumer joined with out-of-date ownedPartition, it won't cause the rebalancing stuck issue. So, the fix is just to allow the consumer lead has a correct version of consumer ownedPartitions to do partition assignment.
   
   Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org