You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/02 04:34:44 UTC
[GitHub] mistercrunch commented on issue #3749: Removing empty filters from explore url
mistercrunch commented on issue #3749: Removing empty filters from explore url
URL: https://github.com/apache/incubator-superset/pull/3749#issuecomment-341315377
I think this helps but ultimately should be handled at the source where the `FilterControl` should not post empty filters. Meaning that the FilterControl internal state might have incomplete filters (say from the moment the user hits `+`, until they set the value), but probably should not communicate back the incomplete filters to the redux state until the filter is set properly. While filters are incomplete/invalid they could show a bit of red.
Once its fixed at the source we could have a DB migration to clean the saved slices with empty filters.
All of this may not be super hi-pri though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services