You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/03 00:52:32 UTC

[GitHub] [tvm] masahi edited a comment on pull request #7572: [Vulkan] Support passing 64 bit scalar

masahi edited a comment on pull request #7572:
URL: https://github.com/apache/tvm/pull/7572#issuecomment-789337533


   `ArgUnion` is also used by other runtime (cuda/opencl I think) https://github.com/apache/tvm/blob/1831c17998b29f3797f364410980809bfef554ca/src/runtime/pack_args.h#L143
   
   I was not sure / haven't look if we can replace this with 64. Since `ArgUnion` only supports 32 bit and I haven't seen any issue with it, I'm not sure if replacing this with 64 bit union is a good idea. Thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org