[GitHub] [flink] bytesandwich commented on a change in pull request #15898: [FLINK-21439][core] WIP: Adds Exception History for AdaptiveScheduler

[GitBox <gi...@apache.org>]

bytesandwich commented on a change in pull request #15898:
URL: https://github.com/apache/flink/pull/15898#discussion_r644384783



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java
##########
@@ -145,14 +151,14 @@
  */
 public class AdaptiveScheduler
         implements SchedulerNG,
-                Created.Context,
-                WaitingForResources.Context,
-                CreatingExecutionGraph.Context,
-                Executing.Context,
-                Restarting.Context,
-                Failing.Context,
-                Finished.Context,
-                StopWithSavepoint.Context {
+        Created.Context,
+        WaitingForResources.Context,
+        CreatingExecutionGraph.Context,
+        Executing.Context,
+        Restarting.Context,
+        Failing.Context,
+        Finished.Context,
+        StopWithSavepoint.Context {

Review comment:
       hi @XComp thanks for pointing that out. my google-java-format plugin was enabled in the plugin install page but was disabled in its own settings, so going through the steps fixed it and removed a lot of noise.
   
   Here are some things you might also consider in your review:
   
   - Maybe Executing and StopWithSavepoint shouldn't always call archiveExecutionFailure as I have in the PR?
   
   - Should we rename the class `FailureHandlingResultSnapshot` to `FailureSnapshot` or something like that?
   
   Will this work? @flinkbot run travis




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org