[jira] [Commented] (AVRO-1248) Add a avro tool that dumps the protocol from a remote RPC service

["Philip Zeyliger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575479#comment-13575479 ] 

Philip Zeyliger commented on AVRO-1248:
---------------------------------------

+1.  This is a great addition.

Two nits:

bq.    List<ByteBuffer> response = transceiver.transceive (byteBufferOutputStream.getBufferList());

I think style dictates no space between transceive and the arguments.

bq. +    transceiver.close(); // can disconnect at this point as all that is left is to output the result

It might be appropriate to put the close() in a finally block to make sure it happens, even if there's an error before that.


                
> Add a avro tool that dumps the protocol from a remote RPC service
> -----------------------------------------------------------------
>
>                 Key: AVRO-1248
>                 URL: https://issues.apache.org/jira/browse/AVRO-1248
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Gareth Davis
>            Priority: Minor
>         Attachments: AVRO-1248.patch
>
>
> Would like to introspect a running RPC service using the avro command line tool.
> expected command would be:
> java -jar avro-tools.jar rpcprotocol uri
> The output would be pretty printed Protocol definition reported by the remote server during the handshake

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira