[jira] [Commented] (SQOOP-2725) Sqoop2: Integration Tests: Prefer using Timestamp types and PreparedStatements for inserting rows into test databases

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047416#comment-15047416 ] 

Sqoop QA bot commented on SQOOP-2725:
-------------------------------------

Testing file [SQOOP-2725.patch|https://issues.apache.org/jira/secure/attachment/12776375/SQOOP-2725.patch] against branch sqoop2 took 0:58:22.191454.

{color:red}Overall:{color} -1 due to an error(s), see details below:

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1640 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1961/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1961/artifact/patch-process/findbugs_report.txt])
{color:red}ERROR:{color} Some of integration tests failed ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1961/artifact/patch-process/test_integration.txt], executed 70 tests)
* Test {{integration-tests}}
* Test {{org.apache.sqoop.integration.connector.jdbc.generic.IncrementalReadTest}}
* Test {{org.apache.sqoop.integration.connector.jdbc.generic.PartitionerTest}}
* Test {{org.apache.sqoop.integration.connector.hdfs.S3Test}}



Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1961/console].

This message is automatically generated.

> Sqoop2: Integration Tests: Prefer using Timestamp types and PreparedStatements for inserting rows into test databases
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2725
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2725
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>         Attachments: SQOOP-2725.patch
>
>
> MySQL, PostgreSQL, and Oracle have slightly different syntaxes for inserting dates that PreparedStatements deal with for us. We should use them when inserting our test data.
> In addition, each database seems to have different ways of printing dates, timestamps seemed to provide the greatest amount of consistency. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)