[GitHub] [nifi] greyp9 commented on a change in pull request #5386: NIFI-9212 - tweak netty shutdown config

[GitBox <gi...@apache.org>]

greyp9 commented on a change in pull request #5386:
URL: https://github.com/apache/nifi/pull/5386#discussion_r708730096



##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/NettyEventSender.java
##########
@@ -25,20 +25,31 @@
 import org.apache.nifi.event.transport.EventSender;
 
 import java.net.SocketAddress;
+import java.util.concurrent.TimeUnit;
 
 /**
  * Netty Event Sender with Channel Pool
  *
  * @param <T> Event Type
  */
 class NettyEventSender<T> implements EventSender<T> {
+    static final long SHUTDOWN_QUIET_PERIOD = 2000;  // netty default
+    static final long SHUTDOWN_TIMEOUT = 15000;  // netty default
+    static final TimeUnit SHUTDOWN_TIME_UNIT = TimeUnit.MILLISECONDS;
+
     private final EventLoopGroup group;
 
     private final ChannelPool channelPool;
 
     private final SocketAddress remoteAddress;
 
-    private boolean singleEventPerConnection;
+    private final boolean singleEventPerConnection;
+
+    private final long shutdownQuietPeriod;
+
+    private final long shutdownTimeout;
+
+    private final TimeUnit shutdownTimeUnit;

Review comment:
       I was originally modeling after the netty API.  But this suggestion does reduce the complexity; thanks. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org