You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/08/09 20:38:56 UTC
Review Request 61539: Can't register multiple PATCH versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61539/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-21693
https://issues.apache.org/jira/browse/AMBARI-21693
Repository: ambari
Description
-------
Fix issues when installing PATHC/MAINT VDF and matching repos.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 77c09d403c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java 95e608a86b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java df15d27df3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java a297d945ce
Diff: https://reviews.apache.org/r/61539/diff/1/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 61539: Can't register multiple PATCH versions
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61539/#review182554
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
Lines 244-247 (patched)
<https://reviews.apache.org/r/61539/#comment258458>
DaoUtils catches exceptions - you shouldn't need the try/catch.
- Jonathan Hurley
On Aug. 9, 2017, 4:38 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61539/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2017, 4:38 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-21693
> https://issues.apache.org/jira/browse/AMBARI-21693
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix issues when installing PATCH/MAINT VDF and matching repos.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 77c09d403c
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java 95e608a86b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java df15d27df3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java a297d945ce
>
>
> Diff: https://reviews.apache.org/r/61539/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> Tests run: 4409, Failures: 0, Errors: 0, Skipped: 30
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:26.422s
> [INFO] Finished at: Wed Aug 09 16:38:00 EDT 2017
> [INFO] Final Memory: 70M/2037M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>