You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "mu578 (via GitHub)" <gi...@apache.org> on 2023/08/28 12:51:34 UTC
[GitHub] [nuttx] mu578 commented on a diff in pull request #10428: battery:add FAR for battery_gauge_operations_s
mu578 commented on code in PR #10428:
URL: https://github.com/apache/nuttx/pull/10428#discussion_r1307384394
##########
include/nuttx/power/battery_gauge.h:
##########
@@ -93,31 +93,32 @@ struct battery_gauge_operations_s
{
/* Return the current battery state (see enum battery_status_e) */
- int (*state)(struct battery_gauge_dev_s *dev, int *status);
+ int (*state)(FAR struct battery_gauge_dev_s *dev, FAR int *status);
Review Comment:
Maybe should explain what is `segmented memory` and why it is important those addresses been accessible outside their respective segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org