[GitHub] [superset] john-bodley commented on a change in pull request #17995: fix: Workaround for sqlparse issue #652

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #17995:
URL: https://github.com/apache/superset/pull/17995#discussion_r781741058



##########
File path: superset/sql_parse.py
##########
@@ -41,6 +42,16 @@
 logger = logging.getLogger(__name__)
 
 
+# Workaround for https://github.com/andialbrecht/sqlparse/issues/652.
+sqlparse.keywords.SQL_REGEX.insert(

Review comment:
       @etr2460 I guess one could replace it though the position could change. This is a pattern I've used elsewhere where I simply increase the priority of the match by inserting it at the top of the list.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org