You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "tqchen (via GitHub)" <gi...@apache.org> on 2025/09/26 00:21:37 UTC

[PR] [FFI][ABI] Bump tvm-ffi version to reflect RC ABI Update [tvm]

tqchen opened a new pull request, #18345:
URL: https://github.com/apache/tvm/pull/18345

   This PR bumps tvm-ffi version. The latest version contains a change to the RC ABI that also needs web runtime update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FFI][ABI] Bump tvm-ffi version to reflect RC ABI Update [tvm]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #18345:
URL: https://github.com/apache/tvm/pull/18345#issuecomment-3336332502

   ## Summary of Changes
   
   Hello @tqchen, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request synchronizes the project's `tvm-ffi` submodule and its web runtime with a recent RC ABI update. The core purpose is to ensure that the web environment correctly interprets and handles object type indices following the ABI change, thereby maintaining system stability and compatibility across different components.
   
   ### Highlights
   
   * **FFI Submodule Update**: The `tvm-ffi` submodule has been updated to a newer commit (`13436f01111bc4218feb440a29a2e421bc148cc4`), reflecting recent changes, including an RC ABI update.
   * **Web Runtime Compatibility**: The web runtime's memory handling (`web/src/memory.ts`) has been adjusted to maintain compatibility with the new RC ABI, specifically by modifying how object type indices are loaded.
   * **ABI Change Adaptation**: The `loadObjectTypeIndex` function in `web/src/memory.ts` now includes an offset of `SizeOf.I64` when loading the object type index, adapting to the updated RC ABI structure.
   
   
   
   
   
   
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
   </details>
   
   
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FFI][ABI] Bump tvm-ffi version to reflect RC ABI Update [tvm]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #18345:
URL: https://github.com/apache/tvm/pull/18345#discussion_r2380581576


##########
web/src/memory.ts:
##########
@@ -175,7 +175,7 @@ export class Memory {
    * @returns The object type index.
    */
   loadObjectTypeIndex(objectHandle: Pointer): number {
-    return this.loadI32(objectHandle);
+    return this.loadI32(objectHandle + SizeOf.I64);

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   While this change is correct according to the RC ABI update, the reason for adding `SizeOf.I64` is not immediately obvious from the code. Adding a comment explaining that the object header layout is now `[ref_counter (i64), type_index (i32), ...]` and that this offset is to skip the reference counter would improve code clarity and maintainability.
   
   ```typescript
       // The object layout is [ref_counter (i64), type_index (i32), ...].
       return this.loadI32(objectHandle + SizeOf.I64);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FFI][ABI] Bump tvm-ffi version to reflect RC ABI Update [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #18345:
URL: https://github.com/apache/tvm/pull/18345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org