You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bitchelov <gi...@git.apache.org> on 2016/12/12 14:17:10 UTC
[GitHub] zeppelin pull request #1747: Minor changes
GitHub user bitchelov opened a pull request:
https://github.com/apache/zeppelin/pull/1747
Minor changes
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
Remove this unused import, naming convention
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bitchelov/zeppelin hdfsFileInterpreterSmallChanges
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1747.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1747
----
commit 6d27bb8d9350ba1830d3b1c618838b8631cfed16
Author: Unknown <so...@gmail.com>
Date: 2016-12-12T14:14:12Z
Minor changes
Remove this unused import, naming convention
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1747: [MINOR] Remove unused import. Naming convention.
Posted by bitchelov <gi...@git.apache.org>.
Github user bitchelov commented on the issue:
https://github.com/apache/zeppelin/pull/1747
@lresende is it right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1747: Minor changes
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1747
Could you please update the title and the PR description with high level description of your changes even if we still mar it as [MINOR].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1747: Remove unused import. Naming convention.
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1747
Overall, the code changes LGTM.
As for the PR, I would recommend :
1. Add [MINOR] to the title, as this is going to be the commit title
2. Respond the "What is this pr for"
3. Respond what type of PR this is
4. Remove todos and all other sections below
Then it should be good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1747: Remove unused import. Naming convention.
Posted by bitchelov <gi...@git.apache.org>.
Github user bitchelov commented on the issue:
https://github.com/apache/zeppelin/pull/1747
@lresende Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1747: [MINOR] Remove unused import. Naming convention...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1747
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1747: [MINOR] Remove unused import. Naming convention.
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1747
LGTM. Merging if there's no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---