You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/17 03:23:03 UTC
[GitHub] [inlong] kinfuy opened a new pull request, #6936: [INLONG-6935][Dashboard] Data flow configuration, new Key Value format
kinfuy opened a new pull request, #6936:
URL: https://github.com/apache/inlong/pull/6936
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #6935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] ZuoFengZhang commented on pull request #6936: [INLONG-6935][Dashboard] Add Key-Value format for InlongStream
Posted by GitBox <gi...@apache.org>.
ZuoFengZhang commented on PR #6936:
URL: https://github.com/apache/inlong/pull/6936#issuecomment-1360662381
The value of `datatype` configured on the front end is not passed to StreamSource, the default is csv format:
https://github.com/apache/inlong/blob/master/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java#L123
https://github.com/apache/inlong/blob/master/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/kafka/KafkaSourceOperator.java#L109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] ZuoFengZhang commented on pull request #6936: [INLONG-6935][Dashboard] Add Key-Value format for InlongStream
Posted by GitBox <gi...@apache.org>.
ZuoFengZhang commented on PR #6936:
URL: https://github.com/apache/inlong/pull/6936#issuecomment-1360790749
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #6936: [INLONG-6935][Dashboard] Add Key-Value format for InlongStream
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #6936:
URL: https://github.com/apache/inlong/pull/6936#issuecomment-1360675077
> The value of `datatype` configured on the front end is not passed to StreamSource, the default is csv format:
>
> https://github.com/apache/inlong/blob/master/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java#L123
>
> https://github.com/apache/inlong/blob/master/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/kafka/KafkaSourceOperator.java#L109
Could you add another PR to make sure the manager supports the KV type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6936: [INLONG-6935][Dashboard] Data flow configuration, new Key Value format
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6936:
URL: https://github.com/apache/inlong/pull/6936#discussion_r1052912183
##########
inlong-dashboard/src/metas/streams/common/StreamDefaultInfo.ts:
##########
@@ -105,6 +105,10 @@ export class StreamDefaultInfo implements DataWithBackend, RenderRow, RenderList
label: 'CSV',
value: 'CSV',
},
+ {
+ label: 'Key-Value',
+ value: 'Key-Value',
Review Comment:
It is found that the Manager does not support it yet.
Suggest using `KV` when communicating with the Manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] ZuoFengZhang commented on pull request #6936: [INLONG-6935][Dashboard] Add Key-Value format for InlongStream
Posted by GitBox <gi...@apache.org>.
ZuoFengZhang commented on PR #6936:
URL: https://github.com/apache/inlong/pull/6936#issuecomment-1360796087
> > The value of `datatype` configured on the front end is not passed to StreamSource, the default is csv format:
> > https://github.com/apache/inlong/blob/master/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java#L123
> > https://github.com/apache/inlong/blob/master/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/kafka/KafkaSourceOperator.java#L109
>
> Could you add another PR to make sure the manager supports the KV type?
I have another pr, just fixed it.
https://github.com/apache/inlong/pull/7001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6936: [INLONG-6935][Dashboard] Add Key-Value format for InlongStream
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6936:
URL: https://github.com/apache/inlong/pull/6936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on a diff in pull request #6936: [INLONG-6935][Dashboard] Data flow configuration, new Key Value format
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #6936:
URL: https://github.com/apache/inlong/pull/6936#discussion_r1051735366
##########
inlong-dashboard/src/metas/streams/common/StreamDefaultInfo.ts:
##########
@@ -105,6 +105,10 @@ export class StreamDefaultInfo implements DataWithBackend, RenderRow, RenderList
label: 'CSV',
value: 'CSV',
},
+ {
+ label: 'Key-Value',
+ value: 'Key-Value',
Review Comment:
We need to confirm how to communicate with the manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #6936: [INLONG-6935][Dashboard] Data flow configuration, new Key Value format
Posted by GitBox <gi...@apache.org>.
leezng commented on code in PR #6936:
URL: https://github.com/apache/inlong/pull/6936#discussion_r1051731624
##########
inlong-dashboard/src/metas/streams/common/StreamDefaultInfo.ts:
##########
@@ -105,6 +105,10 @@ export class StreamDefaultInfo implements DataWithBackend, RenderRow, RenderList
label: 'CSV',
value: 'CSV',
},
+ {
+ label: 'Key-Value',
+ value: 'Key-Value',
Review Comment:
Should the value communicated with the manager be `KV` here?
Such as:
https://github.com/apache/inlong/blob/45d98689f146431258eefdd9148cde64daf9a020/inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/stream/InlongStreamRequest.java#L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org