You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2018/03/09 20:48:27 UTC

[GitHub] jena pull request #379: Refactor tests; don't test for GregorianYear< 0

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/379

    Refactor tests; don't test for GregorianYear< 0

    Follow on from JENA-1503.
    
    This splits up some `TestTypeLiteral` tests and removes the old testing for GregorianYear< 0 which didn't test correctly, and couldn't.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena test_tidy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #379
    
----
commit daf349022c2188345ba4630e4e074594b697bda2
Author: Andy Seaborne <an...@...>
Date:   2018-03-09T16:47:57Z

    Refactor tests; don't test for GregorianYear< 0

----


---

[GitHub] jena issue #379: Refactor tests; don't test for GregorianYear< 0

Posted by ajs6f <gi...@git.apache.org>.

Github user ajs6f commented on the issue:

    https://github.com/apache/jena/pull/379
  
    Ok, `testDateTime_9` LGTM and if the others are just cut-and-paste, it should all be good.


---

[GitHub] jena pull request #379: Refactor tests; don't test for GregorianYear< 0

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/379


---

[GitHub] jena issue #379: Refactor tests; don't test for GregorianYear< 0

Posted by afs <gi...@git.apache.org>.

Github user afs commented on the issue:

    https://github.com/apache/jena/pull/379
  
    Added zero.  I split one mega test (`testDateTime`) into parts. It was a sequence of independent parts. The same testing is done so that it is easier to work on any failures. `testDateTime_9` contains a chag e- don't touch years < 0 because of the GregorianCalendar issue.



---