You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/13 20:22:22 UTC

[GitHub] [beam] melaniedc commented on a diff in pull request #24948: Fix incorrect parsing of None value parameters.

melaniedc commented on code in PR #24948:
URL: https://github.com/apache/beam/pull/24948#discussion_r1069988910


##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -284,6 +284,10 @@ def from_dictionary(cls, options):
           flags.append('--%s=%s' % (k, i))
       elif isinstance(v, dict):
         flags.append('--%s=%s' % (k, json.dumps(v)))
+      elif v is None:

Review Comment:
   Added a unit test case and confirmed it fails without and passes with my change in my local env.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org