You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/29 08:28:00 UTC
[GitHub] [flink] zentol opened a new pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase
zentol opened a new pull request #17602:
URL: https://github.com/apache/flink/pull/17602
Run scalastyle in the same phase as other source QA plugins like checkstyle/spotless. This makes it easier to run locally because you don't have to go through the packaging step again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17602:
URL: https://github.com/apache/flink/pull/17602#issuecomment-954553527
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17602:
URL: https://github.com/apache/flink/pull/17602#issuecomment-954553762
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e (Fri Oct 29 08:31:04 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17602:
URL: https://github.com/apache/flink/pull/17602#issuecomment-954553527
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25627",
"triggerID" : "a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25627)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17602:
URL: https://github.com/apache/flink/pull/17602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17602:
URL: https://github.com/apache/flink/pull/17602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17602:
URL: https://github.com/apache/flink/pull/17602#issuecomment-954553527
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25627",
"triggerID" : "a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6a5d73a54c1d3ab9d125c14c5f33bb20351bd9e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25627)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17602:
URL: https://github.com/apache/flink/pull/17602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org