You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 03:32:44 UTC

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1097: feat: "upstream" i18n

LiteSun commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548782425



##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -61,10 +68,12 @@ export default {
   'upstream.step.healthy.checks.successes': 'Successes',
   'upstream.step.input.healthy.checks.successes': 'Please input successes',
   'upstream.step.healthy.checks.http_failures': 'HttpFailures',
+  'upstream.step.healthy.checks.active.create.req_headers': 'Creat req_headers',
   'upstream.step.input.healthy.checks.http_failures': 'Please input httpFailures',
   'upstream.step.healthy.checks.active.req_headers': 'req_headers',
   'upstream.step.input.healthy.checks.active.req_headers': 'Please input req_headers',
   'upstream.step.healthy.checks.passive': 'Passive',
+  'upstream.step.healthy.checks.passive.create.http_statuses': 'Creat http_statuses',

Review comment:
       ditto

##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -61,10 +68,12 @@ export default {
   'upstream.step.healthy.checks.successes': 'Successes',
   'upstream.step.input.healthy.checks.successes': 'Please input successes',
   'upstream.step.healthy.checks.http_failures': 'HttpFailures',
+  'upstream.step.healthy.checks.active.create.req_headers': 'Creat req_headers',

Review comment:
       ```suggestion
     'upstream.step.healthy.checks.active.create.req_headers': 'Create req_headers',
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org