[GitHub] [incubator-eventmesh] jinrongluo commented on a change in pull request #369: [Issue #368] Fix Racing condition and memory leak issue in EventMesh SDK LiteConsumer and LiteProducer

[GitBox <gi...@apache.org>]

jinrongluo commented on a change in pull request #369:
URL: https://github.com/apache/incubator-eventmesh/pull/369#discussion_r640622874



##########
File path: eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/AbstractLiteClient.java
##########
@@ -46,4 +53,22 @@ public LiteClientConfig getLiteClientConfig() {
     public void shutdown() throws Exception {
         logger.info("AbstractLiteClient shutdown");
     }
+
+    public CloseableHttpClient setHttpClient() throws Exception {

Review comment:
       TrustManager[] tm = new TrustManager[]{new MyX509TrustManager()}; 
   
   This line is throwing generic Exception. So it might not be appropriate to declare specific Exception in the method signature.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org