You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/02 21:51:13 UTC

[GitHub] ashokei opened a new pull request #12008: [WIP] Enable graph partitioning in executor with types/shape awareness

ashokei opened a new pull request #12008: [WIP] Enable graph partitioning in executor with types/shape awareness 
URL: https://github.com/apache/incubator-mxnet/pull/12008
 
 
   ## Description ##
   
   The initial changes have graph executor changes, we plan to extend these changes to CachedOp based on feedback.
   
   This PR tries to address below two tasks from subgraph TODO #11896
   
   * enable graph partitioning in CachedOp and bind of the symbol executor.
     infer shape/dtype/storage info before graph partitioning and pass nnvm::Graph that carries * * 
    * shape/dtype/storage info as an argument when creating a subgraph node.
   
   Sample flow:
   symbol -> bind -> infer shape/type on given symbol (no full graph) -> partition pass for given accelerator using default subgraph property -> construct full graph/gradient in graph.ex -> continue execution as before.
   
   Accelerators can replace default subgraph property with their own customized subgraph property that can take advantage of types/shape attr on the graph in partitioning pass.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services