[jira] [Commented] (TAVERNA-968) Update/remove custom executeworkflow.sh in Taverna Server

["Stian Soiland-Reyes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAVERNA-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282787#comment-15282787 ] 

Stian Soiland-Reyes commented on TAVERNA-968:
---------------------------------------------

I moved the customizations of the server to the executeworkflow.sh and executeworkflow.bat of the commandline.



> Update/remove custom executeworkflow.sh in Taverna Server
> ---------------------------------------------------------
>
>                 Key: TAVERNA-968
>                 URL: https://issues.apache.org/jira/browse/TAVERNA-968
>             Project: Apache Taverna
>          Issue Type: Bug
>          Components: Taverna Commandline, Taverna Server
>            Reporter: Stian Soiland-Reyes
>            Priority: Blocker
>             Fix For: commandline 3.1.0
>
>
> https://builds.apache.org/user/stain/my-views/view/taverna/job/incubator-taverna-server/136/console
> failed with
> {code}
> [INFO] --- exec-maven-plugin:1.2.1:exec (improve-registry-coverage) @ taverna-server-webapp ---
> Error: Unable to access jarfile /home/jenkins/jenkins-slave/workspace/incubator-taverna-server/taverna-server-webapp/target/TavernaServer.3.1.0-incubating-SNAPSHOT/WEB-INF/classes/util/taverna-command-line-3.1.0-incubating-SNAPSHOT/lib/taverna-command-line-0.1.1.jar
> {code}
> It seems there is a custom executeworkflow.sh in 
> https://github.com/apache/incubator-taverna-server/blob/master/taverna-server-webapp/src/main/replacementscripts/executeworkflow.sh
> Do we still need that? in which case the path should be updated to the equivalent of {{lib/org.apache.taverna.commandline.taverna-commandline-api-3.1.0-incubating-SNAPSHOT.jar}}
> Or should we not rather add whatever special it adds to the "proper" executeworkflow.sh in Taverna Command Line now before the release? (I've set this as a blocker for the 3.1.0 Command Line)
> Is it lines like this?
> {code}
> RUNID_PROP= 
> if test x != "x$TAVERNA_RUN_ID"; then
>     RUNID_PROP="-Dtaverna.runid=$TAVERNA_RUN_ID"
> fi
> INTERACTION_PROPS=-Dtaverna.interaction.ignore_requests=true
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)