You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/04/02 22:58:19 UTC
Review Request 19959: Ambari Views : need to add view tables for upgrade
catalog
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19959/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Sid Wagle.
Bugs: AMBARI-5329
https://issues.apache.org/jira/browse/AMBARI-5329
Repository: ambari
Description
-------
Need to add an UpgradeCatalog151 to add the new tables during upgrade. getTargetVersion() should return "1.5.1"
see View Tables in create DDL ...
ambari.viewmain
ambari.viewinstancedata
ambari.viewinstance
ambari.viewinstanceproperty
ambari.viewparameter
ambari.viewresource
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 6065d95
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/19959/diff/
Testing
-------
Results :
Tests run: 1518, Failures: 0, Errors: 0, Skipped: 10
...
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:00.132s
[INFO] Finished at: Wed Apr 02 16:31:52 EDT 2014
[INFO] Final Memory: 35M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 19959: Ambari Views : need to add view tables for upgrade
catalog
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19959/#review39374
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On April 2, 2014, 11:33 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19959/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 11:33 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sid Wagle.
>
>
> Bugs: AMBARI-5329
> https://issues.apache.org/jira/browse/AMBARI-5329
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Need to add an UpgradeCatalog151 to add the new tables during upgrade. getTargetVersion() should return "1.5.1"
>
> see View Tables in create DDL ...
> ambari.viewmain
> ambari.viewinstancedata
> ambari.viewinstance
> ambari.viewinstanceproperty
> ambari.viewparameter
> ambari.viewresource
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 6065d95
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 44fdb1a
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql fbcc219
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4b96984
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19959/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 1518, Failures: 0, Errors: 0, Skipped: 10
>
> ...
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:00.132s
> [INFO] Finished at: Wed Apr 02 16:31:52 EDT 2014
> [INFO] Final Memory: 35M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 19959: Ambari Views : need to add view tables for upgrade
catalog
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19959/
-----------------------------------------------------------
(Updated April 2, 2014, 11:33 p.m.)
Review request for Ambari, Nate Cole and Sid Wagle.
Changes
-------
Made the view FK constraint names shorter for the Oracle limit and made the column viewmain.lable nullable, as Sid suggested.
Bugs: AMBARI-5329
https://issues.apache.org/jira/browse/AMBARI-5329
Repository: ambari
Description
-------
Need to add an UpgradeCatalog151 to add the new tables during upgrade. getTargetVersion() should return "1.5.1"
see View Tables in create DDL ...
ambari.viewmain
ambari.viewinstancedata
ambari.viewinstance
ambari.viewinstanceproperty
ambari.viewparameter
ambari.viewresource
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 6065d95
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java PRE-CREATION
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 44fdb1a
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql fbcc219
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4b96984
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/19959/diff/
Testing
-------
Results :
Tests run: 1518, Failures: 0, Errors: 0, Skipped: 10
...
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:00.132s
[INFO] Finished at: Wed Apr 02 16:31:52 EDT 2014
[INFO] Final Memory: 35M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 19959: Ambari Views : need to add view tables for upgrade
catalog
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19959/#review39356
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java
<https://reviews.apache.org/r/19959/#comment71717>
Is label required field ?
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java
<https://reviews.apache.org/r/19959/#comment71718>
FK constraint might be too long for Oracle.
echo FK_viewinstanceproperty_view_name | wc -c
34
- Sid Wagle
On April 2, 2014, 8:58 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19959/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 8:58 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sid Wagle.
>
>
> Bugs: AMBARI-5329
> https://issues.apache.org/jira/browse/AMBARI-5329
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Need to add an UpgradeCatalog151 to add the new tables during upgrade. getTargetVersion() should return "1.5.1"
>
> see View Tables in create DDL ...
> ambari.viewmain
> ambari.viewinstancedata
> ambari.viewinstance
> ambari.viewinstanceproperty
> ambari.viewparameter
> ambari.viewresource
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 6065d95
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19959/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 1518, Failures: 0, Errors: 0, Skipped: 10
>
> ...
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:00.132s
> [INFO] Finished at: Wed Apr 02 16:31:52 EDT 2014
> [INFO] Final Memory: 35M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 19959: Ambari Views : need to add view tables for upgrade
catalog
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19959/#review39367
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 2, 2014, 4:58 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19959/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 4:58 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sid Wagle.
>
>
> Bugs: AMBARI-5329
> https://issues.apache.org/jira/browse/AMBARI-5329
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Need to add an UpgradeCatalog151 to add the new tables during upgrade. getTargetVersion() should return "1.5.1"
>
> see View Tables in create DDL ...
> ambari.viewmain
> ambari.viewinstancedata
> ambari.viewinstance
> ambari.viewinstanceproperty
> ambari.viewparameter
> ambari.viewresource
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 6065d95
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19959/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 1518, Failures: 0, Errors: 0, Skipped: 10
>
> ...
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:00.132s
> [INFO] Finished at: Wed Apr 02 16:31:52 EDT 2014
> [INFO] Final Memory: 35M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>