You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CrazyHZM (GitHub)" <gi...@apache.org> on 2019/02/20 06:47:36 UTC
[GitHub] [incubator-dubbo] CrazyHZM opened pull request #3517: fix
Endpoint address is missing in WSDL with webserivce protocol
## What is the purpose of the change
fix Endpoint address is missing in WSDL with webserivce protocol #1655 #3411
I recently researched the source code of the relevant cxf and found that two changes in the cxf 2.7.x and 3.2.x versions affected this bug.
1.HTTPTransportFactory no longer implements the WSDLEndpointFactory interface
2.the disableAddressUpdates parameter in the ServletController default to true, and the default is false before.
For the first problem, I solved it in the code. For the second problem, because it involves the initialization parameters of the servlet, if you follow the settings below, you can solve this problem.
` <servlet>
<servlet-name>dubbo</servlet-name>
<servlet-class>org.apache.dubbo.remoting.http.servlet.DispatcherServlet</servlet-class>
<init-param>
<param-name>disable-address-updates</param-name>
<param-value>false</param-value>
</init-param>
</servlet>
`
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3517 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM closed pull request #3517: fix
Endpoint address is missing in WSDL with webserivce protocol
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
[ pull request closed by CrazyHZM ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3517 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3517: fix
Endpoint address is missing in WSDL with webserivce protocol
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3517?src=pr&el=h1) Report
> Merging [#3517](https://codecov.io/gh/apache/incubator-dubbo/pull/3517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f415fda0347e4ea6f75a1e62d05b8d560b051670?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3517 +/- ##
============================================
- Coverage 64.08% 64.08% -0.01%
Complexity 71 71
============================================
Files 664 665 +1
Lines 28618 28622 +4
Branches 4771 4771
============================================
Hits 18341 18341
- Misses 8055 8060 +5
+ Partials 2222 2221 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3517?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../rpc/protocol/webservice/HttpTransportFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy13ZWJzZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvd2Vic2VydmljZS9IdHRwVHJhbnNwb3J0RmFjdG9yeS5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...bo/rpc/protocol/webservice/WebServiceProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy13ZWJzZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvd2Vic2VydmljZS9XZWJTZXJ2aWNlUHJvdG9jb2wuamF2YQ==) | `74.57% <33.33%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <0%> (-5.13%)` | `0% <0%> (ø)` | |
| [...bbo/registry/support/ProviderConsumerRegTable.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVyQ29uc3VtZXJSZWdUYWJsZS5qYXZh) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `78.04% <0%> (-2.44%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `70.27% <0%> (-0.68%)` | `0% <0%> (ø)` | |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `58.13% <0%> (+2.32%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `21.05% <0%> (+5.26%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3517/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3517?src=pr&el=footer). Last update [f415fda...61baea0](https://codecov.io/gh/apache/incubator-dubbo/pull/3517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3517 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org