[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42797: [SPARK-45068][SQL] Make math function output column name displayed in upper-cased style

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #42797:
URL: https://github.com/apache/spark/pull/42797#discussion_r1320899020


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -880,7 +885,7 @@ case class IntegralDivide(
     DecimalType.bounded(if (intDig == 0) 1 else intDig, 0)
   }
 
-  override def sqlOperator: String = "div"
+  override def sqlOperator: String = "DIV"

Review Comment:
   apology I joined this party late. Seems like doing uppercase also needs a lot of changes? How big is it to make all lowercased? Otherwise, I tend to think that it might not be so worthwhile fixing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org