You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2016/02/24 22:16:06 UTC
[GitHub] cordova-docs pull request: Add CLI reference and Create your first...
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/519
Add CLI reference and Create your first app article
Please review this commit: a6e1da5. The others are part of this pending PR #516
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs cliDoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/519.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #519
----
commit a986ec3ad0b0a35e2815f07a4de38903f549724f
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2016-02-23T17:30:18Z
Improve gulp watch perf and add --nofetch option
commit e94557f05545661e955d71bb44a82944fcf8ea6e
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2016-02-24T17:44:05Z
Responding to code review feedback
commit a6e1da5b081aaa10db1a3cbc6afd67123d954291
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2016-02-24T19:43:39Z
Create your first app doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add CLI reference and Create your first...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/519#discussion_r54038571
--- Diff: www/_layouts/docs.html ---
@@ -189,7 +189,7 @@ <h2 class="site-toc-title">{{ page.toc_text }}</h2>
<span aria-hidden="true">×</span>
</button>
{{ page.plugin_version_text }} {{ page.plugin_version }}.
- <a href="https://github.com/{{ page.plugin_name }}/releases">
+ <a href="https://github.com/apache/{{ page.plugin_name }}/releases">
--- End diff --
Good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add CLI reference and Create your first...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/519#discussion_r54044465
--- Diff: gulpfile.js ---
@@ -232,7 +235,7 @@ gulp.task("serve", ["build"], function () {
});
});
-gulp.task("build", ["configs", "data", "styles", "plugins"], function (done) {
+gulp.task("build", [ "configs", "data", "styles", "plugins"], function (done) {
jekyllBuild(done);
});
--- End diff --
@nikhilkh Just a small note: these changes made it in accidentally. I'm doing a slight refactor and I'll revert them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add CLI reference and Create your first...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add CLI reference and Create your first...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/519#issuecomment-188456154
@rakatyal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org