[GitHub] [hudi] leesf commented on a change in pull request #4152: [HUDI-2881] Compact the file group with larger log files to reduce wr…

[GitBox <gi...@apache.org>]

leesf commented on a change in pull request #4152:
URL: https://github.com/apache/hudi/pull/4152#discussion_r759330065



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java
##########
@@ -166,6 +166,11 @@
       .withDocumentation("Amount of MBs to spend during compaction run for the LogFileSizeBasedCompactionStrategy. "
           + "This value helps bound ingestion latency while compaction is run inline mode.");
 
+  public static final ConfigProperty<Long> COMPACTION_LOG_FILE_SIZE_THRESHOLD = ConfigProperty
+      .key("hoodie.compaction.logfile.size.threshold")
+      .defaultValue(1024 * 1024 * 1024L)
+      .withDocumentation("Only if the log file size is greater than the threshold, the file group will be compacted.");

Review comment:
       nit:than the threshold -> than the threshold in bytes?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org