You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/08 22:41:55 UTC

[GitHub] [tvm] mbrookhart opened a new pull request #7423: Simplify full broadcast

mbrookhart opened a new pull request #7423:
URL: https://github.com/apache/tvm/pull/7423


   This PR simplifies full like ops that can be fused into broadcast ops, such that we can enable constant folding these ops in other situations to fix various issues we've seen with dynamic models. 
   
   This also refactors the SimplifyExpr pass somewhat to ease the addition of future patterns.
   
   @vinx13 @jwfromm @icemelon9 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on a change in pull request #7423: Simplify full broadcast

Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #7423:
URL: https://github.com/apache/tvm/pull/7423#discussion_r573301638



##########
File path: src/relay/transforms/fold_constant.cc
##########
@@ -148,7 +148,7 @@ class ConstantFolder : public MixedModeMutator {
     }
     static auto op_stateful = Op::GetAttrMap<TOpIsStateful>("TOpIsStateful");
 
-    std::unordered_set<std::string> skip_list{"zeros_like", "ones_like", "full_like", "full"};
+    std::unordered_set<std::string> skip_list{};

Review comment:
       Remove it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 commented on pull request #7423: Simplify full broadcast

Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #7423:
URL: https://github.com/apache/tvm/pull/7423#issuecomment-776974366


   Thanks @mbrookhart @masahi 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 merged pull request #7423: Simplify full broadcast

Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #7423:
URL: https://github.com/apache/tvm/pull/7423


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org