You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Abhishek Dasgupta <a1...@linux.vnet.ibm.com> on 2017/01/17 19:18:34 UTC
Re: Review Request 54574: Updated test case for call based metrics for
scheduler api.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54574/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 7:18 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Zhitao Li.
Bugs: MESOS-6082
https://issues.apache.org/jira/browse/MESOS-6082
Repository: mesos
Description
-------
Updated test case for call based metrics for scheduler api.
Diffs (updated)
-----
src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e
Diff: https://reviews.apache.org/r/54574/diff/
Testing
-------
Manual Test:
1. sudo ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
2. sudo ./bin/mesos-slave.sh --master=127.0.0.1:5050 --ip=0.0.0.0 --work_dir=/var/lib/mesos
3. curl -v -H "Accept: application/json" -H "Content-Type: application/json" -d "@subscribe.json" http://127.0.0.1:5050/api/v1/scheduler
4. curl -v -H "Accept: application/json" -H "Content-Type: application/json" -H "Mesos-Stream-Id: 000a38b7-8a2a-4c8f-a374-f782d6ea617f" -d "@teardown.json" http://127.0.0.1:5050/api/v1/scheduler
5. Checked the subscribe call metric and teardown call metric in http://127.0.0.1:5050/metrics/snapshot - it's updated
On Ubuntu 16.04:
sudo GTEST_FILTER="MetricsTest.Master" make -j`nproc` check
Thanks,
Abhishek Dasgupta
Re: Review Request 54574: Updated test case for call based metrics for
scheduler api.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54574/#review161947
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54572, 54573, 54574]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos ReviewBot
On Jan. 17, 2017, 7:18 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54574/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 7:18 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Zhitao Li.
>
>
> Bugs: MESOS-6082
> https://issues.apache.org/jira/browse/MESOS-6082
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated test case for call based metrics for scheduler api.
>
>
> Diffs
> -----
>
> src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e
>
> Diff: https://reviews.apache.org/r/54574/diff/
>
>
> Testing
> -------
>
> Manual Test:
> 1. sudo ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> 2. sudo ./bin/mesos-slave.sh --master=127.0.0.1:5050 --ip=0.0.0.0 --work_dir=/var/lib/mesos
> 3. curl -v -H "Accept: application/json" -H "Content-Type: application/json" -d "@subscribe.json" http://127.0.0.1:5050/api/v1/scheduler
> 4. curl -v -H "Accept: application/json" -H "Content-Type: application/json" -H "Mesos-Stream-Id: 000a38b7-8a2a-4c8f-a374-f782d6ea617f" -d "@teardown.json" http://127.0.0.1:5050/api/v1/scheduler
> 5. Checked the subscribe call metric and teardown call metric in http://127.0.0.1:5050/metrics/snapshot - it's updated
>
> On Ubuntu 16.04:
> sudo GTEST_FILTER="MetricsTest.Master" make -j`nproc` check
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>