You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/08/18 21:16:21 UTC
[GitHub] trafficserver pull request #880: TS-4763: Consistent request bytes logging t...
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/880
TS-4763: Consistent request bytes logging tags.
Make the byte count logging tags consistent. We have
- ``cqbl`` - client request body length
- ``cqhl`` - client request header length
- ``pscl`` - client response body length
- ``pshl`` - client response header length
- ``psql`` - client response total length
- ``pqbl`` - server request body length
- ``pqhl`` - server request header length
- ``sscl`` - server response body length
- ``sshl`` - server response header length
We should add ``*ql`` to get the missing totals and standardize on ``*cl`` for the content length (``csscl`` marginally tips the balance towards "content length" in favor of "body length").
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4763
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #880
----
commit 7e12104cecd01a1f93d3bfb35d60b41ba705f2a3
Author: James Peach <jp...@apache.org>
Date: 2016-08-18T18:42:15Z
TS-4764: Return the aligned field size from marshal_client_req_uuid().
commit d81b884237806ff93236fe8bf11b8e4e66233aa6
Author: James Peach <jp...@apache.org>
Date: 2016-08-18T20:29:25Z
TS-4763: Rename body_len log acces methods.
Standardize on content_len terminology for logging, so rename
"body_len" log access methods to "content_len".
commit 52d9a6abdf9ceea3a6a39a746c642c48957c57e8
Author: James Peach <jp...@apache.org>
Date: 2016-08-18T20:37:38Z
TS-4763: Rename cqbl and pqbl log fields to cqcl and pqcl.
commit 94f4cb9d1962394db1f9a0e816ae5574159f70ff
Author: James Peach <jp...@apache.org>
Date: 2016-08-18T21:12:37Z
TS-4763: Add the ssql, cqql, pqql, and cssql log fields.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #880: TS-4763: Consistent request bytes logging t...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/880#discussion_r75419974
--- Diff: proxy/logging/LogAccess.cc ---
@@ -326,11 +328,11 @@ LogAccess::marshal_proxy_resp_content_type(char *buf)
/*-------------------------------------------------------------------------
-------------------------------------------------------------------------*/
-int
-LogAccess::marshal_proxy_resp_squid_len(char *buf)
-{
- DEFAULT_INT_FIELD;
-}
+LOG_ACCESS_DEFAULT_FIELD(marshal_proxy_resp_squid_len, DEFAULT_INT_FIELD)
+LOG_ACCESS_DEFAULT_FIELD(marshal_client_req_squid_len, DEFAULT_INT_FIELD)
+LOG_ACCESS_DEFAULT_FIELD(marshal_proxy_req_squid_len, DEFAULT_INT_FIELD)
+LOG_ACCESS_DEFAULT_FIELD(marshal_server_resp_squid_len, DEFAULT_INT_FIELD)
+LOG_ACCESS_DEFAULT_FIELD(marshal_cache_resp_squid_len, DEFAULT_INT_FIELD)
--- End diff --
I guess I'm ok with this, just seems a little odd and wildly different from all other similar code, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #880: TS-4763: Consistent request bytes logging tags.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/880
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/554/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #880: TS-4763: Consistent request bytes logging tags.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/880
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/558/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #880: TS-4763: Consistent request bytes logging t...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/880#discussion_r75420890
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -769,8 +782,11 @@ LogAccessHttp::marshal_client_req_uuid(char *buf)
const char *uuid = (char *)Machine::instance()->uuid.getString();
int len;
- len = snprintf(str, _MAX_CRUUID_LEN, "%s-%" PRId64 "", uuid, m_http_sm->sm_id);
- marshal_str(buf, str, round_strlen(len + 1));
+ len = snprintf(str, sizeof(str), "%s-%" PRId64 "", uuid, m_http_sm->sm_id);
--- End diff --
> On Aug 18, 2016, at 7:25 PM, Leif Hedstrom <no...@github.com> wrote:
>
> In proxy/logging/LogAccessHttp.cc:
>
> > @@ -769,8 +782,11 @@ LogAccessHttp::marshal_client_req_uuid(char *buf)
> > const char *uuid = (char *)Machine::instance()->uuid.getString();
> > int len;
> >
> > - len = snprintf(str, _MAX_CRUUID_LEN, "%s-%" PRId64 "", uuid, m_http_sm->sm_id);
> > - marshal_str(buf, str, round_strlen(len + 1));
> > + len = snprintf(str, sizeof(str), "%s-%" PRId64 "", uuid, m_http_sm->sm_id);
> Isn't this fixed/addressed in a separate PR?
>
Yeh I just branched this from the other PR
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #880: TS-4763: Consistent request bytes logging tags.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/880
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/454/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #880: TS-4763: Consistent request bytes logging tags.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/880
/cc @zwoop @bryancall @sudheerv
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #880: TS-4763: Consistent request bytes logging t...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #880: TS-4763: Consistent request bytes logging t...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/880#discussion_r75419879
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -769,8 +782,11 @@ LogAccessHttp::marshal_client_req_uuid(char *buf)
const char *uuid = (char *)Machine::instance()->uuid.getString();
int len;
- len = snprintf(str, _MAX_CRUUID_LEN, "%s-%" PRId64 "", uuid, m_http_sm->sm_id);
- marshal_str(buf, str, round_strlen(len + 1));
+ len = snprintf(str, sizeof(str), "%s-%" PRId64 "", uuid, m_http_sm->sm_id);
--- End diff --
Isn't this fixed/addressed in a separate PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #880: TS-4763: Consistent request bytes logging tags.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/880
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/450/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---