You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2024/07/30 19:08:56 UTC
[I] Rework OpTimer and NanoTime [accumulo]
DomGarguilo opened a new issue, #4777:
URL: https://github.com/apache/accumulo/issues/4777
This ticket is based on [this discussion](https://github.com/apache/accumulo/pull/4380#pullrequestreview-2201429835). Below are some points to summarize what is being suggested to be done here:
- [ ] Merge `OpTimer` into `NanoTime` since they have a large overlap in functionality.
- [ ] Rename `NanoTime` to something else since it doesn't expose nanosecond units at all. Some suggestions are "Stopwatch," "ElapsedTime," or "Timer."
- [ ] Add a `hasElapsed(Duration)` method to make comparisons more efficient and more readable.
- [ ] Add a `reset()` method to make it easier to reuse the object.
Since `OpTimer` is in the 2.1 branch and only `NanoTime` is in main and later, it would be beneficial to standardize the usage across these branches. Specifically, after the new `Timer` class is created, we should:
1. Identify places in the 2.1 branch where `NanoTime` would be beneficial but currently can't be used because it doesn't exist in that branch.
2. Replace `OpTimer` with the new `Timer` class in the 2.1 branch.
3. Ensure the new `Timer` class is used consistently across all branches.
The replacing and consistency steps will be handled in a separate PR after the initial changes are completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Rework OpTimer and NanoTime [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on issue #4777:
URL: https://github.com/apache/accumulo/issues/4777#issuecomment-2265901992
Closing via #4784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Rework OpTimer and NanoTime [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo closed issue #4777: Rework OpTimer and NanoTime
URL: https://github.com/apache/accumulo/issues/4777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org