You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sandeep Tata (JIRA)" <ji...@apache.org> on 2009/04/04 01:02:13 UTC

[jira] Created: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Add new call to API: get_slice_by_name_range
--------------------------------------------

                 Key: CASSANDRA-53
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
             Project: Cassandra
          Issue Type: New Feature
         Environment: all
            Reporter: Sandeep Tata


A new get call that lets you get all the columns between colStart and colEnd like:

get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)


This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandeep Tata updated CASSANDRA-53:
----------------------------------

    Attachment: CASSANDRA-53-interface.patch
                CASSANDRA-53-src-tests.patch

The src/test patch contains:

1. SliceByRangeReadCommand class, changes to ReadCommand to support this and associated unit tests.
2. A new getRow call in Table using RangeFilter to support this command.
3. Added a unit test in TableTest.

Interface patch contains changes to thrift and the generated code:


> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718823#action_12718823 ] 

Hudson commented on CASSANDRA-53:
---------------------------------

Integrated in Cassandra #106 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/106/])
    add system test for slice_by_name_range.  patch by Sandeep Tata; reviewed by jbellis for 


> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface-V2.patch, CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests-V2.patch, CASSANDRA-53-src-tests.patch, systemtest.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandeep Tata updated CASSANDRA-53:
----------------------------------

    Attachment: systemtest.patch

System test exercising get_slice_by_name_range

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface-V2.patch, CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests-V2.patch, CASSANDRA-53-src-tests.patch, systemtest.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-53.
-------------------------------------

    Resolution: Fixed

nope.  applied system test, resolved ticket.

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface-V2.patch, CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests-V2.patch, CASSANDRA-53-src-tests.patch, systemtest.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718238#action_12718238 ] 

Sandeep Tata commented on CASSANDRA-53:
---------------------------------------

Do we need anything else to close this ticket?

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface-V2.patch, CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests-V2.patch, CASSANDRA-53-src-tests.patch, systemtest.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708743#action_12708743 ] 

Jonathan Ellis commented on CASSANDRA-53:
-----------------------------------------

is this still on your plate?

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>         Environment: all
>            Reporter: Sandeep Tata
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708757#action_12708757 ] 

Sandeep Tata commented on CASSANDRA-53:
---------------------------------------

Yes. I'm waiting for Jun to add his mergesort based access method. He's blocked on a bunch of other changes...

I'll post a patch tomorrow using existing access methods so you can roll this in the 0.3 release. We can rewire this to the new access methods once they're there.

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709950#action_12709950 ] 

Jonathan Ellis commented on CASSANDRA-53:
-----------------------------------------

committed your patches so far, but see if you can add a system test so everything the client sees is tested.  now that you have ubuntu running those should be easy:

$ apt-get install python-setuptools
$ easy_install nose
$ nosetests 

(test/system/test_server.py starts up a new server for each method, and runs the given client code)

no need to start a new ticket for the system test, just add it here.

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface-V2.patch, CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests-V2.patch, CASSANDRA-53-src-tests.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709546#action_12709546 ] 

Jonathan Ellis commented on CASSANDRA-53:
-----------------------------------------

src-tests patch does not apply against trunk.  (interfaces one is fine.)

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710111#action_12710111 ] 

Hudson commented on CASSANDRA-53:
---------------------------------

Integrated in Cassandra #78 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/78/])
    add get_slice_by_name_range command.  patch by Sandeep Tata; reviewed by jbellis for 


> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface-V2.patch, CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests-V2.patch, CASSANDRA-53-src-tests.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis reassigned CASSANDRA-53:
---------------------------------------

    Assignee: Sandeep Tata

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708757#action_12708757 ] 

Sandeep Tata edited comment on CASSANDRA-53 at 5/14/09 3:17 PM:
----------------------------------------------------------------

Yes. I'm waiting for Jun to add his mergesort based access method (CASSANDRA-172). He's blocked on a bunch of other changes...

I'll post a patch tomorrow using existing access methods so you can roll this in the 0.3 release. We can rewire this to the new access methods once they're there.

      was (Author: sandeep_tata):
    Yes. I'm waiting for Jun to add his mergesort based access method. He's blocked on a bunch of other changes...

I'll post a patch tomorrow using existing access methods so you can roll this in the 0.3 release. We can rewire this to the new access methods once they're there.
  
> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandeep Tata updated CASSANDRA-53:
----------------------------------

    Attachment: CASSANDRA-53-src-tests-V2.patch
                CASSANDRA-53-interface-V2.patch

Rebased to trunk with small changes:

1. Changed the name of the function to get_slice_by_name_range (like the ticket originally said).

2. There's a count parameter you can pass in to bound the number of columns to return.

3. Added more tests in testGetRowSliceByRange to exercise this count parameter.



> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: CASSANDRA-53-interface-V2.patch, CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests-V2.patch, CASSANDRA-53-src-tests.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-53) Add new call to API: get_slice_by_name_range

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated CASSANDRA-53:
------------------------------------

    Component/s: Core

> Add new call to API: get_slice_by_name_range
> --------------------------------------------
>
>                 Key: CASSANDRA-53
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-53
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: 0.4
>
>         Attachments: CASSANDRA-53-interface-V2.patch, CASSANDRA-53-interface.patch, CASSANDRA-53-src-tests-V2.patch, CASSANDRA-53-src-tests.patch, systemtest.patch
>
>
> A new get call that lets you get all the columns between colStart and colEnd like:
> get_slice_by_name_range(string tablename,string key,string columnFamily_column, String columnNameStart = "" , String columnNameEnd)
> This would be particularly useful if you were encoding some information in the column names, and couldn't leverage just offset and count to get at the correct set of columns (eg all columns starting with "b").
> It might be fine to support this call only on name sorted column families and throw an UnsupportedException for other columnfamilies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.