You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Mark Combellack (JIRA)" <tu...@ws.apache.org> on 2007/06/01 12:39:16 UTC
[jira] Created: (TUSCANY-1321) The use of is not SCA 1.0
compliant. It is still using SCA 0.96 style
The use of <include> is not SCA 1.0 compliant. It is still using SCA 0.96 style
-------------------------------------------------------------------------------
Key: TUSCANY-1321
URL: https://issues.apache.org/jira/browse/TUSCANY-1321
Project: Tuscany
Issue Type: Bug
Components: Java SCA Assembly Model
Reporter: Mark Combellack
Priority: Minor
The SCA 1.0 specification says includes should be written as:
(From page 47 of SCA 1.0 assembly specification)
<include name="foo:MyValueServices"/>
However, Tuscany still uses the 0.96 style includes:
<include>foo:MyValueServices</include>
If I use the SCA 1.0 format for the include, Tuscany ignores the include.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1321) The use of is not SCA
1.0 compliant. It is still using SCA 0.96 style
Posted by "Mark Combellack (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500664 ]
Mark Combellack commented on TUSCANY-1321:
------------------------------------------
The problem appears to be in the assembly-xml module in CompositeProcessor.java. The code finds the include but does not read it's name
} else if (INCLUDE_QNAME.equals(name)) {
// Read an <include>
include = assemblyFactory.createComposite();
include.setUnresolved(true);
composite.getIncludes().add(include);
}
The code later on reads the name using:
case XMLStreamConstants.CHARACTERS:
// Read an <include>qname</include>
if (include != null && INCLUDE_QNAME.equals(name)) {
include.setName(getQNameValue(reader, reader.getText().trim()));
}
break;
This code is correct for SCA 0.96 style includes.
To make it read SCA 1.0 includes, simply read and set the QName in the first code block.
Care should be taken with this change as it may break all exising includes in the Tuscany project as they use SCA 0.96 style.
> The use of <include> is not SCA 1.0 compliant. It is still using SCA 0.96 style
> -------------------------------------------------------------------------------
>
> Key: TUSCANY-1321
> URL: https://issues.apache.org/jira/browse/TUSCANY-1321
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Reporter: Mark Combellack
> Priority: Minor
>
> The SCA 1.0 specification says includes should be written as:
> (From page 47 of SCA 1.0 assembly specification)
> <include name="foo:MyValueServices"/>
> However, Tuscany still uses the 0.96 style includes:
> <include>foo:MyValueServices</include>
> If I use the SCA 1.0 format for the include, Tuscany ignores the include.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-1321) The use of is not SCA 1.0
compliant. It is still using SCA 0.96 style
Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raymond Feng resolved TUSCANY-1321.
-----------------------------------
Resolution: Fixed
Thank you for reporting this issue. I fixed it under r543519. Please verify.
> The use of <include> is not SCA 1.0 compliant. It is still using SCA 0.96 style
> -------------------------------------------------------------------------------
>
> Key: TUSCANY-1321
> URL: https://issues.apache.org/jira/browse/TUSCANY-1321
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Reporter: Mark Combellack
> Priority: Minor
>
> The SCA 1.0 specification says includes should be written as:
> (From page 47 of SCA 1.0 assembly specification)
> <include name="foo:MyValueServices"/>
> However, Tuscany still uses the 0.96 style includes:
> <include>foo:MyValueServices</include>
> If I use the SCA 1.0 format for the include, Tuscany ignores the include.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org