[GitHub] [superset] dpgaspar commented on a diff in pull request #22744: fix(dependency): update cryptography import

["dpgaspar (via GitHub)" <gi...@apache.org>]

dpgaspar commented on code in PR #22744:
URL: https://github.com/apache/superset/pull/22744#discussion_r1086370858


##########
superset/utils/core.py:
##########
@@ -1550,7 +1550,7 @@ def override_user(user: Optional[User], force: bool = True) -> Iterator[Any]:
         delattr(g, "user")
 
 
-def parse_ssl_cert(certificate: str) -> _Certificate:
+def parse_ssl_cert(certificate: str) -> Certificate:

Review Comment:
   nit: can you use `x509.Certificate` instead or remove the x509 import and import `load_pem_x509_certificate` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org