[GitHub] jschmidt10 commented on a change in pull request #860: Fixes #854 handle many tablets referencing many WALs

[GitBox <gi...@apache.org>]

jschmidt10 commented on a change in pull request #860: Fixes #854 handle many tablets referencing many WALs
URL: https://github.com/apache/accumulo/pull/860#discussion_r244740079
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -2497,6 +2497,38 @@ public void removeInUseLogs(Set<DfsLogger> candidates) {
     candidates.removeAll(referencedLogs);
   }
 
+  public void checkIfMinorCompactionNeededForLogs(List<DfsLogger> closedLogs) {
+
+    // grab this outside of tablet lock.
+    int maxLogs = tableConfiguration.getCount(Property.TABLE_MINC_LOGS_MAX);
+
+    String reason = null;
+    synchronized (this) {
+      if (currentLogs.size() >= maxLogs) {
 
 Review comment:
   Will this effectively subtract 1 from the max logs configuration? If currentLogs.size() is equal to maxLogs, then we'll force a MinC.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services