You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by mm...@apache.org on 2020/12/30 12:10:49 UTC
[accumulo] branch 1.10 updated: Reduce log level of replication
offline retries (#1843)
This is an automated email from the ASF dual-hosted git repository.
mmiller pushed a commit to branch 1.10
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/1.10 by this push:
new 6bf3f40 Reduce log level of replication offline retries (#1843)
6bf3f40 is described below
commit 6bf3f406481a392c5bcffc15d44ccdfd52c2b577
Author: Mike Miller <mm...@apache.org>
AuthorDate: Wed Dec 30 07:10:41 2020 -0500
Reduce log level of replication offline retries (#1843)
* Reduce logging level to trace of retries when replication is offline
* User can easily see if repl table is online through monitor, no need
to keep spamming logs when it is offline
---
.../org/apache/accumulo/master/replication/FinishedWorkUpdater.java | 4 ++--
.../accumulo/master/replication/RemoveCompleteReplicationRecords.java | 2 +-
.../org/apache/accumulo/master/replication/ReplicationDriver.java | 2 +-
.../main/java/org/apache/accumulo/master/replication/WorkDriver.java | 2 +-
.../main/java/org/apache/accumulo/master/replication/WorkMaker.java | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/server/master/src/main/java/org/apache/accumulo/master/replication/FinishedWorkUpdater.java b/server/master/src/main/java/org/apache/accumulo/master/replication/FinishedWorkUpdater.java
index 4495aae..01e89f2 100644
--- a/server/master/src/main/java/org/apache/accumulo/master/replication/FinishedWorkUpdater.java
+++ b/server/master/src/main/java/org/apache/accumulo/master/replication/FinishedWorkUpdater.java
@@ -62,10 +62,10 @@ public class FinishedWorkUpdater implements Runnable {
@Override
public void run() {
- log.debug("Looking for finished replication work");
+ log.trace("Looking for finished replication work");
if (!ReplicationTable.isOnline(conn)) {
- log.debug("Replication table is not yet online, will retry");
+ log.trace("Replication table is not yet online, will retry");
return;
}
diff --git a/server/master/src/main/java/org/apache/accumulo/master/replication/RemoveCompleteReplicationRecords.java b/server/master/src/main/java/org/apache/accumulo/master/replication/RemoveCompleteReplicationRecords.java
index 2d5f431..efa6fc4 100644
--- a/server/master/src/main/java/org/apache/accumulo/master/replication/RemoveCompleteReplicationRecords.java
+++ b/server/master/src/main/java/org/apache/accumulo/master/replication/RemoveCompleteReplicationRecords.java
@@ -74,7 +74,7 @@ public class RemoveCompleteReplicationRecords implements Runnable {
throw new AssertionError("Inconceivable; an exception should have been"
+ " thrown, but 'bs' or 'bw' was null instead");
} catch (ReplicationTableOfflineException e) {
- log.debug("Not attempting to remove complete replication records as the"
+ log.trace("Not attempting to remove complete replication records as the"
+ " table ({}) isn't yet online", ReplicationTable.NAME);
return;
}
diff --git a/server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java b/server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java
index 9ed4409..57a7adc 100644
--- a/server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java
+++ b/server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java
@@ -118,7 +118,7 @@ public class ReplicationDriver extends Daemon {
// Sleep for a bit
long sleepMillis = conf.getTimeInMillis(Property.MASTER_REPLICATION_SCAN_INTERVAL);
- log.debug("Sleeping for {}ms before re-running", sleepMillis);
+ log.trace("Sleeping for {}ms before re-running", sleepMillis);
try {
Thread.sleep(sleepMillis);
} catch (InterruptedException e) {
diff --git a/server/master/src/main/java/org/apache/accumulo/master/replication/WorkDriver.java b/server/master/src/main/java/org/apache/accumulo/master/replication/WorkDriver.java
index dabfc79..785addb 100644
--- a/server/master/src/main/java/org/apache/accumulo/master/replication/WorkDriver.java
+++ b/server/master/src/main/java/org/apache/accumulo/master/replication/WorkDriver.java
@@ -105,7 +105,7 @@ public class WorkDriver extends Daemon {
}
long sleepTime = conf.getTimeInMillis(Property.REPLICATION_WORK_ASSIGNMENT_SLEEP);
- log.debug("Sleeping {} ms before next work assignment", sleepTime);
+ log.trace("Sleeping {} ms before next work assignment", sleepTime);
sleepUninterruptibly(sleepTime, TimeUnit.MILLISECONDS);
// After each loop, make sure that the WorkAssigner implementation didn't change
diff --git a/server/master/src/main/java/org/apache/accumulo/master/replication/WorkMaker.java b/server/master/src/main/java/org/apache/accumulo/master/replication/WorkMaker.java
index 8a06376..4ef5906 100644
--- a/server/master/src/main/java/org/apache/accumulo/master/replication/WorkMaker.java
+++ b/server/master/src/main/java/org/apache/accumulo/master/replication/WorkMaker.java
@@ -67,7 +67,7 @@ public class WorkMaker {
public void run() {
if (!ReplicationTable.isOnline(conn)) {
- log.debug("Replication table is not yet online");
+ log.trace("Replication table is not yet online");
return;
}