You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/09 04:12:30 UTC

[GitHub] [spark] viirya opened a new pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

viirya opened a new pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   We prune nested fields from Generate. If a child output is required in a top operator of Generate, we should not prune nested fields on it. Otherwise, the accessors on top operator could be unresolved.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   A required child output means it is referred as a whole or by its nested fields on top of operator of Generate. If the rule prunes other nested fields from it, the accessors on top operator will be unresolved.
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   Unit tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583802924
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22850/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583802922
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583802922
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583805748
 
 
   @viirya How about reverting the original commit https://github.com/apache/spark/commit/a0e63b61e7c5d55ae2a9213b95ab1e87ac7c203c and then consider how to improve the rule?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583817144
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118085/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583803205
 
 
   **[Test build #118085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118085/testReport)** for PR 27503 at commit [`2e2302f`](https://github.com/apache/spark/commit/2e2302f594fe4be55ef1ba79c0375b2838211320).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583805648
 
 
   > If a child output is required in a top operator of Generate, we should not prune nested fields on it. Otherwise, the accessors on top operator could be unresolved.
   
   Do we traverse all the ancestor nodes? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583803205
 
 
   **[Test build #118085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118085/testReport)** for PR 27503 at commit [`2e2302f`](https://github.com/apache/spark/commit/2e2302f594fe4be55ef1ba79c0375b2838211320).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on a change in pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#discussion_r376755585
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala
 ##########
 @@ -333,6 +333,14 @@ abstract class SchemaPruningSuite
     }
   }
 
+  testSchemaPruning("select explode of nested field of array of struct and " +
+      "all remaining nested fields") {
 
 Review comment:
   Instead of fixing case by case, can we try to find all the possible cases and ensure we can cover all the possible query plans? Includes negative and positive cases. 
   
   Also, we need to have the unit test cases for these optimizer rules. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya opened a new pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
viirya opened a new pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   We prune nested fields from Generate. If a child output is required in a top operator of Generate, we should not prune nested fields on it. Otherwise, the accessors on top operator could be unresolved.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   A required child output means it is referred as a whole or by its nested fields on top of operator of Generate. If the rule prunes other nested fields from it, the accessors on top operator will be unresolved.
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   Unit tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on a change in pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#discussion_r376755585
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala
 ##########
 @@ -333,6 +333,14 @@ abstract class SchemaPruningSuite
     }
   }
 
+  testSchemaPruning("select explode of nested field of array of struct and " +
+      "all remaining nested fields") {
 
 Review comment:
   Instead of fixing case by case, can we try to find all the possible cases? 
   
   Also, we need to have the unit test cases for these optimizer rules. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583817143
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583817144
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118085/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
viirya commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583806136
 
 
   @gatorsmile I'm ok to revert it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583817143
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on a change in pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#discussion_r376753522
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
 ##########
 @@ -179,7 +185,10 @@ object GeneratorNestedColumnAliasing {
 
     case g: Generate if SQLConf.get.nestedSchemaPruningEnabled &&
         canPruneGenerator(g.generator) =>
-      NestedColumnAliasing.getAliasSubMap(g.generator.children).map {
+      // For the child outputs required by the operator on top of `Generate`, we do not want
+      // to prune it.
+      val requiredAttrs = AttributeSet(g.requiredChildOutput)
+      NestedColumnAliasing.getAliasSubMap(g.generator.children, requiredAttrs).map {
 
 Review comment:
   This case normally should be treated by above case pattern (Project + Generate). But if all nested fields are selected at top Project, the above case won't prune. Then when Optimizer transforms down to the underlying Generate, only the referred nested column are kept and others are pruned from the child. It causes the accessors at top Project unresolved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583802924
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22850/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile closed pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
gatorsmile closed pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya closed pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
viirya closed pull request #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583817006
 
 
   **[Test build #118085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118085/testReport)** for PR 27503 at commit [`2e2302f`](https://github.com/apache/spark/commit/2e2302f594fe4be55ef1ba79c0375b2838211320).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org