[jira] [Comment Edited] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior

["Tobias Soloschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321493#comment-14321493 ] 

Tobias Soloschenko edited comment on WICKET-5837 at 2/14/15 3:15 PM:
---------------------------------------------------------------------

For Wicket 7.0.0-M5 the work was already done. The JSONObject in there already uses a LinkedHashMap. The changes are also made for Wicket 6.19.0, now. I also fixed the JUnit test for MultiFileUploadFieldTest in the Wicket 6.19.0 commit.

Edit: Forgot to say that I applied a little change to 7.0.0-M5 so that an JSONObject created based on a Map also uses a LinkedHashMap.


was (Author: klopfdreh):
For Wicket 7.0.0-M5 the work was already done. The JSONObject in there already uses a LinkedHashMap. The changes are also made for Wicket 6.19.0, now. I also fixed the JUnit test for MultiFileUploadFieldTest in the Wicket 6.19.0 commit.

> JUnit tests may fail because of AbstractDefaultAjaxBehavior
> -----------------------------------------------------------
>
>                 Key: WICKET-5837
>                 URL: https://issues.apache.org/jira/browse/WICKET-5837
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.0.0-M5, 6.19.0
>            Reporter: Tobias Soloschenko
>            Assignee: Andrea Del Bene
>              Labels: test
>
> Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes)
> which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run.
> One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order.
> See stack trace in comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)