You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2017/05/31 13:30:56 UTC
[GitHub] incubator-guacamole-manual pull request #46: GUACAMOLE-203: Update SSH docum...
GitHub user necouchman opened a pull request:
https://github.com/apache/incubator-guacamole-manual/pull/46
GUACAMOLE-203: Update SSH documentation to include keepalive interval
Adding the new server-alive-interval parameter to the documentation for SSH connections.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/incubator-guacamole-manual GUACAMOLE-203
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-manual/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit 7c109f68509195da4201e7d9dcd6ef42c5e1e3ba
Author: Nick Couchman <vn...@apache.org>
Date: 2017-05-31T13:22:30Z
GUACAMOLE-203: Update SSH documentation to include keepalive interval.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #46: GUACAMOLE-203: Update SSH docum...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/46#discussion_r123908903
--- Diff: src/chapters/configuring.xml ---
@@ -2772,6 +2794,24 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
session will use the user's default shell.</para>
</entry>
</row>
+ <row>
+ <entry><parameter>server-alive-interval</parameter></entry>
--- End diff --
Moved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #46: GUACAMOLE-203: Update SSH docum...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/46#discussion_r123908400
--- Diff: src/chapters/configuring.xml ---
@@ -2772,6 +2794,24 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
session will use the user's default shell.</para>
</entry>
</row>
+ <row>
+ <entry><parameter>server-alive-interval</parameter></entry>
+ <entry>
+ <para>
+ <indexterm>
+ <primary>SSH</primary>
+ <secondary>server-alive-interval</secondary>
+ </indexterm>
+ By default the SSH client does not send keepalive requests
+ to the server. This parameter allows you to configure the
+ the interval (in seconds) at which the client connection
+ sends keepalive packets to the server. The default is 0,
+ which disables sending the packets. A value of 1 is
--- End diff --
> ... A value of 1 is automatically increased to 2. Negative values are set to 0, disabling sending keepalives.
The "default is zero, one becomes two, negative becomes zero" description seems convoluted/confusing. It makes sense in the code, but this description borders on being pseudocode.
Wouldn't it be easier to understand as simply being disabled by default, with the minimum legal value being 2?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #46: GUACAMOLE-203: Update SSH docum...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-manual/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #46: GUACAMOLE-203: Update SSH docum...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/46#discussion_r123909033
--- Diff: src/chapters/configuring.xml ---
@@ -2772,6 +2794,24 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
session will use the user's default shell.</para>
</entry>
</row>
+ <row>
+ <entry><parameter>server-alive-interval</parameter></entry>
+ <entry>
+ <para>
+ <indexterm>
+ <primary>SSH</primary>
+ <secondary>server-alive-interval</secondary>
+ </indexterm>
+ By default the SSH client does not send keepalive requests
+ to the server. This parameter allows you to configure the
+ the interval (in seconds) at which the client connection
+ sends keepalive packets to the server. The default is 0,
+ which disables sending the packets. A value of 1 is
--- End diff --
Okay, should be cleaned up, now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #46: GUACAMOLE-203: Update SSH docum...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/46#discussion_r123908309
--- Diff: src/chapters/configuring.xml ---
@@ -2772,6 +2794,24 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
session will use the user's default shell.</para>
</entry>
</row>
+ <row>
+ <entry><parameter>server-alive-interval</parameter></entry>
--- End diff --
I'm not sure it makes sense to include the keepalive interval within a new "environment settings" section. Since the keepalive interval deals with the SSH connection itself, what about the existing "network parameters" section?
http://guacamole.incubator.apache.org/doc/gug/configuring-guacamole.html#ssh-network-parameters
IMHO, the keepalive interval is by definition a network parameter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---