You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Anonymitaet (via GitHub)" <gi...@apache.org> on 2023/02/28 07:00:20 UTC
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #432: [improve][doc] Highlight `mTLS` in security docs and update configs/images
Anonymitaet commented on code in PR #432:
URL: https://github.com/apache/pulsar-site/pull/432#discussion_r1119642152
##########
docs/security-tls-transport.md:
##########
@@ -369,7 +380,7 @@ async def test():
asyncio.run(test())
```
-> Note that in addition to the required configurations in the `conf/client.conf` file, you need to configure more parameters in the `conf/broker.conf` file to enable TLS encryption on WebSocket service. For more details, see [security settings for WebSocket](client-libraries-websocket.md/#security-settings).
+> Note that in addition to the required configurations in the `conf/client.conf` file, you need to configure more parameters in the `conf/broker.conf` file to enable TLS encryption on WebSocket service. For more details, see [security settings for WebSocket](client-libraries-websocket.md#security-settings).
Review Comment:
```suggestion
::: note
In addition to the required configurations in the `conf/client.conf` file, you need to configure more parameters in the `conf/broker.conf` file to enable TLS encryption on WebSocket service. For more details, see [security settings for WebSocket](client-libraries-websocket.md#security-settings).
:::
```
```suggestion
> Note that in addition to the required configurations in the `conf/client.conf` file, you need to configure more parameters in the `conf/broker.conf` file to enable TLS encryption on WebSocket service. For more details, see [security settings for WebSocket](client-libraries-websocket.md#security-settings).
```
##########
versioned_docs/version-2.11.x/security-tls-authentication.md:
##########
@@ -1,45 +1,92 @@
---
id: security-tls-authentication
Review Comment:
Is the file name still security-tls-authentication.md not security-mtls-authentication.md?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org