You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/11 20:00:59 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #3162: Remove JARs fom repository to simplify release review
matthiasblaesing opened a new pull request #3162:
URL: https://github.com/apache/netbeans/pull/3162
- Mock jars in maven project used for unittests only contain a pom.properties
file and are generated at test runtime
- empty.jar used in autoupdate services unittest is generated with other
signed jars at test build time
- dummy jar files for tests of versioned jar suffix matcher of glassfish
and payara tooling are generated at test runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3162: Remove JARs fom repository to simplify release review
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3162:
URL: https://github.com/apache/netbeans/pull/3162#issuecomment-941384473
I still think this is a cleanup and in general improves the build. If anyone wants to object, now would be a good time. I intend to merge this on the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #3162: Remove JARs fom repository to simplify release review
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #3162:
URL: https://github.com/apache/netbeans/pull/3162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed pull request #3162: Remove JARs fom repository to simplify release review
Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed pull request #3162:
URL: https://github.com/apache/netbeans/pull/3162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3162: Remove JARs fom repository to simplify release review
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3162:
URL: https://github.com/apache/netbeans/pull/3162#issuecomment-945003428
Thank you again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3162: Remove JARs fom repository to simplify release review
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3162:
URL: https://github.com/apache/netbeans/pull/3162#issuecomment-927022642
+1
Throw rocks at me, but I like this!
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3162: Remove JARs fom repository to simplify release review
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3162:
URL: https://github.com/apache/netbeans/pull/3162#issuecomment-941384473
I still think this is a cleanup and in general improves the build. If anyone wants to object, now would be a good time. I intend to merge this on the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3162: Remove JARs fom repository to simplify release review
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3162:
URL: https://github.com/apache/netbeans/pull/3162#issuecomment-931501306
I pushed another set of cleanups. Given that pack200 compression will go away and thus the NBMs become unreviewable and other code here was zipped "just because", I don't see this as a bad changeset. None the less, PR #3190 shows, that the cases are not clear and it is not clear, what "we want", so settings this as "do not merge".
To be clear: This is ready to merge, but I don't see consensus whether it should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists