[GitHub] [druid] github-code-scanning[bot] commented on a diff in pull request #13922: Refactoring and bug fixes on top of unnest. The allowList now is not passed …

["github-code-scanning[bot] (via GitHub)" <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #13922:
URL: https://github.com/apache/druid/pull/13922#discussion_r1135028741


##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/CorrelateProjectOnFIlterRightTransposeRule.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.sql.calcite.rule;
+
+import com.google.common.collect.ImmutableList;
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Correlate;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Project;
+import org.apache.calcite.rel.core.Uncollect;
+import org.apache.calcite.rex.RexUtil;
+import org.apache.calcite.sql.SqlKind;
+
+/**
+ * Rule that pulls a {@link Filter} from the right-hand side of a {@link Correlate} above the Correlate in presence of an unneeded Project
+ * Allows filters on unnested fields to be added to queries that use {@link org.apache.druid.query.UnnestDataSource}.
+ *
+ * @see CorrelateFilterRTransposeRule similar, but for without a Project atop Filter
+ */
+public class CorrelateProjectOnFIlterRightTransposeRule extends RelOptRule
+{
+  private static final CorrelateProjectOnFIlterRightTransposeRule INSTANCE = new CorrelateProjectOnFIlterRightTransposeRule();
+
+  public CorrelateProjectOnFIlterRightTransposeRule()
+  {
+    super(
+        operand(
+            Correlate.class,
+            operand(RelNode.class, any()),
+            operand(Project.class, operand(Filter.class, operand(Uncollect.class, any())))
+        ));
+  }
+
+  @Override
+  public boolean matches(RelOptRuleCall call)
+  {
+    final Correlate correlate = call.rel(0);
+    final Filter right = call.rel(3);
+
+    // Can't pull up filters that explicitly refer to the correlation variable.
+    return !CorrelateFilterRTransposeRule.usesCorrelationId(correlate.getCorrelationId(), right.getCondition());
+  }
+
+  public static CorrelateProjectOnFIlterRightTransposeRule instance()
+  {
+    return INSTANCE;
+  }
+
+  @Override
+  public void onMatch(RelOptRuleCall call)
+  {
+    final Correlate correlate = call.rel(0);
+    final RelNode left = call.rel(1);
+    final Project rightP = call.rel(2);
+    final Filter rightF = call.rel(3);
+    final Uncollect uncollect = call.rel(4);

Review Comment:
   ## Unread local variable
   
   Variable 'Uncollect uncollect' is never read.
   
   [Show more details](https://github.com/apache/druid/security/code-scanning/4393)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org