[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #1958:
URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503965858



##########
File path: arch/xtensa/include/arch.h
##########
@@ -91,6 +91,18 @@ extern "C"
 #define EXTERN extern
 #endif
 
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
+
+struct mallinfo; /* Forward reference, see malloc.h */
+
+void      up_imm_initialize(void);
+FAR void *up_imm_malloc(size_t size);
+void      up_imm_free(FAR void *mem);
+FAR void *up_imm_memalign(size_t alignment, size_t size);
+bool up_imm_heapmember(FAR void *mem);
+int up_imm_mallinfo(FAR struct mallinfo *info);
+#endif
+

Review comment:
       The naming up_imm_* does not follow the NuttX naming conventions.  These should all be xtensa_imm_* .  See https://cwiki.apache.org/confluence/display/NUTTX/Naming+of+Architecture%2C+MCU%2C+and+Board+Interfaces




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org