You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/07/13 16:00:25 UTC
[GitHub] [logging-log4j2] sman-81 opened a new pull request #548: LOG4J2-2885: Added support for US-style date patterns and micro/nano seconds
sman-81 opened a new pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 edited a comment on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
sman-81 edited a comment on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999
Hi @carterkozak, hi @vy,
thank you both for fixing the `revapi` build failure which I have reproduced earlier.
I should have spotted this myself. I must admit I've rarely built the whole project as it takes long (log4j-core ~ 15 minutes) and I assumed the suite was never green - but it actually is 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999
Hi @carterkozak, hi @vy,
thank you both for fixing the **reviapi** build failure.
I should have spotted this myself. I must admit I've rarely built the whole project as it takes long (log4j-core ~ 15 minutes) and I assumed the suite was never green - but it actually is 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-892717422
@vy I think this broke builds on release-2.x for the same reason the PR build is failing, revapi needs the enum ordinal changes to be acknowledged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy merged pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
vy merged pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 commented on pull request #548: LOG4J2-2885: Added support for US-style date patterns and micro/nano seconds
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-891590238
How will you proceed with my PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893239718
:man_facepalming: @carterkozak, right, thanks for the warning, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-892391568
Thanks so much for the PR @sman-81! I have ported this to `master` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 edited a comment on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
sman-81 edited a comment on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999
Hi @carterkozak, hi @vy,
thank you both for fixing the `revapi` build failure which I have reproduced earlier.
I should have spotted this myself. I must admit I've rarely built the whole project as it takes long (log4j-core ~ 15 minutes) and I assumed the suite was never green - but it actually is 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-892717422
@vy I think this broke builds on release-2.x for the same reason the PR build is failing, revapi needs the enum ordinal changes to be acknowledged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999
Hi @carterkozak, hi @vy,
thank you both for fixing the **reviapi** build failure.
I should have spotted this myself. I must admit I've rarely built the whole project as it takes long (log4j-core ~ 15 minutes) and I assumed the suite was never green - but it actually is 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893239718
:man_facepalming: @carterkozak, right, thanks for the warning, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org